Update SiteConfiguration.php #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for the new homepage footer option as well as background color choices for the above and below content regions.
Add check box to have normal `<header>` display or not. Used for the homepage only so it is added to the advanced options.
jcsparks
requested changes
Nov 12, 2024
| ], | ||
| '#description' => $this->t('Check this box if you would like to display the "Be Boulder" slogan in the header.'), | ||
| ]; | ||
| $form['advanced']['ucb_homepage_header'] = [ |
Member
There was a problem hiding this comment.
Can we get rid of the double-negative here, parsing this is confusing. Also it's unchecked but not displaying by default. We want it unchecked by default but displaying, currently this would wipe out the site title for every site even though it's not checked.
Updated language.
jcsparks
approved these changes
Nov 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Update SiteConfiguration.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for the new homepage footer option as well as background color choices for the above and below content regions.
Sister PR: CuBoulder/tiamat-theme#1456